Hi Prasanna, Neil et al,
first thanks for your reviews!
I did update the webrev (make sure to reload) to include more
information within the comment like Prasanna suggested.
Let me know if there is anything else to be changed.
Greets
Thorsten
Prasanna Kunisetty wrote:
> Thorsten,
>
> The change looks fine, but just one small comment below.
> On 03/10/09 06:25, Thorsten Frueauf wrote:
>> Hi,
>>
>> in a previous review I did introduce the usage of ipmpstat to
>> accommodate the IPMP changes from project Clearview within the sczbt
>> component of the HA Containers agent.
>>
>> Peter Memishian rightly pointed out to me that parsing the output from
>> "ipmpstat -g" is not being a stable interface.
>>
>> Instead the -P option together with -o must be used to use a stable
>> interface moving forward. I did create CR 6815384 to track this.
>>
>> Please review the small change at
>> http://cr.opensolaris.org/~frueauf/colorado-1-ha-ipkg-zone-6815384
>>
>> Example output of "ipmpstat -g":
>>
>> # ipmpstat -g
>> GROUP GROUPNAME STATE FDT INTERFACES
>> ipmp0 sc_ipmp0 ok -- e1000g0
>>
>> Example output of "ipmpstat -o group,groupname -P -g":
>>
>> # ipmpstat -o group,groupname -P -g
>> ipmp0:sc_ipmp0
> I believe after your change below:
>
> ADAPTER_LIST=$(${IPMPSTAT} -o group,groupname -P -g | /bin/nawk -F: -v
> ipmpgroup="${IPMP_GROUP}" '{ if ($2 == ipmpgroup) print $1 }')
>
> ADAPTER_LIST contains the "ipmp0" pseudo interface name and not the real
> adapter names like in non-clearview case.
> It would be great if you can add this info to the comments section
> before the above code.
>
> Thanks,
> Prasanna
>
>>
>> Greets
>> Thorsten
>>
--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Sitz der Gesellschaft:
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Amtsgericht Muenchen: HRB 161028
Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Haering
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
