Hi Ritu, The changes look good to me. Just one general comment though (you might not want to fix it right away)
- There is not much of a difference right now in cliutil and guiutil classes. It might be a good approach to have a common base class util, from which both classes can inherit. That ways we would not have code duplicity. This common class would reside in cluster core packages, thus making sure packaging is right. Or is there any specific reason to keep them separate which I have totally missed ? Thanks, Madhur On 03/13/09 06:28, Ritu Agrawal wrote: > Hi, > > We recently ran into some build issues when we sync'd up the Colorado > gate with the latest changes in the osc-gate. This is because we had > added code for the wizards to remove the dependency on JATO. However, > these changes are present only in the Colorado gate and not in the > osc-gate causing the builds to fail after the sync up. > > The code review at http://cr.opensolaris.org/~ritua/wiz-merge-issues/ > takes care of these build failures. Most of the changes in the code > review are simply because of the merge with the osc-gate.The two files > that should be looked at closely are the CliUtil.java and GuiUtil.java. > > Thanks > Ritu > _______________________________________________ > ha-clusters-discuss mailing list > ha-clusters-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
