Hi Jonathan, Thanks for your review comments. Please see my replies inline.
On 06/27/09 03:31, Jonathan Mellors wrote: > Hi Hemachandran, > > The Makefile and packaging changes look fine. The source files should > not be executable so you need to run chmod -x on: > usr/src/cmd/ha-services/gds-agents/xvm/SUNW.ldom > usr/src/cmd/ha-services/gds-agents/xvm/validate_xvm.ksh > usr/src/cmd/ha-services/gds-agents/xvm/lib/libgetpassphrase.c > > and their SCCS/s.files. > Fixed it. > You appear to have mixed the CDDL header from the gds template with > the actual one we use for our source tree. They should all refer to > usr/src/CDDL.txt, and the SUNW.* files should contain it as well. > Fixed it. Please find the updated webrev at http://cr.opensolaris.org/~hnamachi/ha-ldom/ > usr/src/pkgdefs/jas.dvdimage.ksh: > xvm for S10/i386? > The HA-xVM for "domU"s were targeted only for SXCE editions. Maybe Neil can comment on this. -Thanks and Regards Hemachandran > Thanks > Jonathan > > Hemachandran Namachivayam wrote: >> Hi Folks, >> >> I'd welcome the code review for the "Solaris cluster failover agent >> for LDoms Guest domains" >> >> The failover agent for LDoms Guest domains is an extension of the >> HA-xVM agent and introduces a new resource type SUNW.ldom. The agent >> is redesigned to use the Generic Data Service (SUNW.gds) binaries and >> hence the resource type (SUNW.xvm) have been reworked upon. The >> HA-xVM agent makes use of CCR to store the xVM/LDom guest domain >> configuration; thereby a need to configure a separate admin directory >> is eliminated. >> >> To refer to the requirements specification and design document, >> please visit http://opensolaris.org/os/project/ha-xvm/ >> >> The webrev, for review, is located at >> http://cr.opensolaris.org/~hnamachi/ha-ldom/ >> >> -Thanks and Regards >> Hemachandran >> >> _______________________________________________ >> ha-clusters-discuss mailing list >> ha-clusters-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
