Hi Marty, Thanks for your comments. I have added an additional check to test the return status of cl_exec_client command at line 324.
Please find the updated webrev @ http://cr.opensolaris.org/~hnamachi/ha-ldom/. -Regards Hemachandran Martin Rattner wrote: > Hemachandran, > > The changes look good. > > The lines you inserted at line 314 check for the node being up to fix > CR 6861658 . This should work fine almost always, but there is still a > slight chance that the node goes down immediately after you check it > at line 314, but before executing ${CL_EXEC_CLIENT} at line 320. To > make this bulletproof, perhaps you could check for an error return > from ${CL_EXEC_CLIENT} that would catch the case of the node being > down? If it is feasible to do that check, and if it finds that the > node has died, you could 'continue' to the next node in the list at > that point. > > --Marty > > On 07/21/09 05:09, Hemachandran Namachivayam wrote: >> Hi Folks, >> >> Can you please review the changes made for the below CR's. The webrev >> is @ http://cr.opensolaris.org/~hnamachi/ha-ldom/. >> >> CR 6861658 /opt/SUNWscgds/bin/../../SUNWscxvm/bin/validate_xvm[46]: >> is: bad number if node is down >> >> Description: >> If one of the cluster node is down the validate method throws the ksh >> error message ": is: bad number ". >> >> Solution: >> The domain related checks have to be skipped if the node is down. >> >> CR 6861119 Validation should check for failure-policy=reset on master >> instead of guest domain >> >> Description: >> The validate method should check if the failure-policy is to "reset" >> on the primary instead of the guest domain. The 'failure-policy' >> property should be set on the master as this determines what the >> slaves will do when the master fails. >> >> Solution: >> Validate method will query the failure-policy setting on control >> domain (i.e primary). >> >> -Thanks and Regards >> Hemachandran >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> ha-clusters-discuss mailing list >> ha-clusters-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss >>
