Thanks, I'm fine with the changes.

On 28 Jul 2009, at 11:07, Hemachandran Namachivayam wrote:

> Hi Neil,
>
> Thanks for your comments. I have incorporated the changes you have  
> suggested. The updated webrev is @ 
> http://cr.opensolaris.org/~hnamachi/ha-ldom/ 
> .
>
> -Regards
> Hemachandran
>
> On 07/28/09 15:32, Neil Garthwaite wrote:
>>
>> Hi Hemachandran,
>>
>> Looks good, although I have a couple of comments.
>>
>> usr/src/cmd/ha-services/gds-agents/xvm/functions.ksh
>>
>> Line 331 is missing "${policy}" as the 2nd argument to i18n_message.
>>
>>
>> Line 379 is missing "${DOMAIN}" as the 2nd argument to i18n_message.
>>
>>
>> Regards
>> Neil
>>
>>
>> On 28 Jul 2009, at 10:34, Hemachandran Namachivayam wrote:
>>
>>> Hi Folks,
>>>
>>> Can you please review the changes made for the below CR's. The  
>>> webrev is @ http://cr.opensolaris.org/~hnamachi/ha-ldom/.
>>>
>>> CR *6865006* ldom validate shouldn't check for password file if  
>>> migration type is set to normal
>>> Solution:
>>> The password file related checks have to be skipped if the  
>>> MIGRATION_TYPE is set to NORMAL.
>>>
>>> CR *6864993* HA-xVM validate messages need to be wrapped by gettext
>>> Solution:
>>> The validate messages which appear on the terminal are wrapped by  
>>> gettext.
>>>
>>> -Thanks and Regards
>>> Hemachandran
>>> _______________________________________________
>>> ha-clusters-discuss mailing list
>>> ha-clusters-discuss at opensolaris.org
>>> http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: 
<http://mail.opensolaris.org/pipermail/ha-clusters-discuss/attachments/20090728/8e812e2c/attachment.html>

Reply via email to