Ganesh,

>>> usr/src/cmd/clcommands/commands/clnode/clnode_cmd.h
>>>>
>>>> 64 #define CLNODE_SUBCMD_RESOLVE_CONFIG            \
>>>>    65         GETTEXT("Resolves the cluster weak membership during split
>>>> brain")
>>>>
>>>> The rest of the messages seem to be imperative rather than descriptive,
>>>> so this one should probably be, "Resolve the..." instead of "Resolves
>>>> the..."
>>>>
>>>> Also, I don't think the description is quite right. This doesn't resolve
>>>> "weak membership", it resolves the CCR configuration changes that
>>>> occurred during weak membership. And it's not run during split brain,
>>>> rather after the cluster is back together.
>>>>
>>>>   
>>>>       
>>> Lisa commented on the same text and we modified it to "Resolve split 
>>> brain in a weak-membership cluster".
>>> Should this be modified to "Resolve cluster configuration conflicts in a 
>>> weak-membership cluster" ?
>>>     
>> Yes, I prefer "cluster configuration conflicts".
>>
>> The point I think I was trying to make about "split-brain" was that this 
>> command is run after the split-brain has been resolved. So just changing 
>> "split-brain" to "weak-membership" I don't think really helps. I'd 
>> prefer something like, "Resolve cluster configuration conflicts that 
>> occurred during a split-brain." Or something like that.
>>
>>   
> I guess the subcommand name is generic hence we should put it as 
> "Resolve cluster configuration conflicts"
> without the reference to split-brain.
> 
> Would this work ?

That's fine with me.

Thanks,
Nick

Reply via email to