On 01/14/09 13:10, Nicholas Solter wrote:
> Yue Lai wrote:
>   
>> Hi,
>>
>> Please review the fix to CR 6792249 at
>>
>> http://cr.opensolaris.org/~llai/6792249/
>>
>> Thanks,
>>
>> - Lucia
>>     
>
> Lucia,
>
> usr/src/cmd/scsnapshot/scsnapshot.ksh
> usr/src/lib/scsnapshot/ScSnapshot/Makefile
>
> Can you add some comments explaining why you're changing the way the 
> include paths are specified, so that in the future we don't make the 
> same mistake?
>   
Will add comments to both files.

>
> usr/src/lib/libexpat/xml_parser/Makefile
>
> Is there any way we can avoid hard-coding a perl version? Otherwise 
> we'll face the same problem again next time the version is reved and the 
> old version is not available.
>   
I thought about it, but since it uses $(PERL_DIR)/lib, and there is no 
generic way to refer to in different versions of Perl. If you have any 
ideas let me know.

Thanks,

- Lucia
> Thanks,
> Nick
> _______________________________________________
> ha-clusters-discuss mailing list
> ha-clusters-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
>   

-------------- next part --------------
An HTML attachment was scrubbed...
URL: 
<http://mail.opensolaris.org/pipermail/ha-clusters-discuss/attachments/20090114/157ba53b/attachment.html>

Reply via email to