Hi, The PostgreSQL agent definitely does not suffer the problem you described in your blog, because it uses a different wait for online mechanism. and the rolechanger does not have one at all.
But the change does not harm. Especially using sleep directly was an oversight and violates the coding style of the agent, because I used fully qualified commands stored in variables at the rest of the code. So go ahead. The swift agent would suffer the effect described in your blog, because as long as the start_sag command is running, the real probe algorithm will not be called and the probe will return 100 all the time and so you will hit the timeout. No complaints about the changes. Detlef Thorsten Frueauf wrote: > Hi, > > if you had asked yourself why I changed some calls for sleep from shell > internal to full qualified path in my last code review I send out for > the ipkg support added to the HA Containers agent, then you can read the > ksh93 related reason here: > http://blogs.sun.com/TF/entry/unexpected_ksh93_behaviour_with_build > > I did a further audit (just by looking through the code) to identify > sleep being called and send to background. This identified occasions at > the PostgreSQL and SWIFT agents. I don't think they will run into the > same problem as identified within the blog, but I would like to make > those small changes just to make sure. > > The webrev is available for review at > http://cr.opensolaris.org/~frueauf/Colorado-agent-sleep-audit/ > > This review will timeout at Friday, 23. January 2009 COB MET. > > Greets > Thorsten > -- ***************************************************************************** Detlef Ulherr Staff Engineer Tel: (++49 6103) 752-248 Availability Engineering Fax: (++49 6103) 752-167 Sun Microsystems GmbH Amperestr. 6 mailto:detlef.ulherr at sun.com 63225 Langen http://www.sun.de/ ***************************************************************************** Sitz der Gesellschaft: Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht Muenchen: HRB 161028 Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer Vorsitzender des Aufsichtsrates: Martin Haering *****************************************************************************
