lucia lai wrote: > Thanks Nick for reviewing it. See inline. Thanks, Lucia. Nick
> > Nicholas Solter wrote: >> Yue Lai wrote: >> >>> Hi, >>> >>> Please review the changes for Colorado IPS package refactory at >>> >>> http://cr.opensolaris.org/~llai/col_refactory/ >>> >>> >>> >> Lucia, >> >> Thanks for doing this package refactoring work. It looks like it was >> quite tedious. Here are a few comments: >> >> usr/src/ipsdefs/SUNWsc/manifest_i386 >> usr/src/ipsdefs/SUNWsc/manifest_sparc >> >> Why did you drop the zone_cluster files from these manifests? >> > zone_cluster files exist in both manifest_i386 and manifest_sparc. Since > IPS starts from opensolaris (s11), so I moved them into manifest_com, > and leave manifest_i386|sparc only contain the files specific to i386/sparc. >> usr/src/ipsdefs/SUNWscspm/depend_auto >> usr/src/ipsdefs/SUNWscspm/depend_static >> >> I'm confused as to how the spm package could have no dependencies. >> > There should be. But it was not there before the refactory. I'll look > into the depend files (whatever I can do) after the refactory is done. > For refactory changes, I only tried to make package name changes in the > dependent files caused by refactory. >> usr/src/ipsdefs/SUNWscz/manifest_i386 >> usr/src/ipsdefs/SUNWscz/manifest_sparc >> >> Why did you remove files from here? Did they get added to manifest_com? >> > Same idea as SUNWsc. Yes they were added into mafest_com. > > Thanks, > - Lucia >> Thanks, >> Nick >> _______________________________________________ >> ha-clusters-discuss mailing list >> ha-clusters-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss >> > > _______________________________________________ > ha-clusters-discuss mailing list > ha-clusters-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
