Btw, I also suggest that:
http://cr.opensolaris.org/~jmellors/ohac-tools-ksh88-93/usr/src/tools/scripts/chk.ksh.html
51 (cd "$f" && /bin/pwd)
53 ${ECHO} $(cd $(dirname "$f") && /bin/pwd)/$(basename "$f")
192 cd ${GATE}/usr/src || exit 1
instead of:
51 (cd "$f"; /bin/pwd)
53 ${ECHO} $(cd $(dirname "$f"); /bin/pwd)/$(basename "$f")
192 cd ${GATE}/usr/src
On Sat, Apr 4, 2009 at 10:44 AM, Piotr Jasiukajtis <estseg at gmail.com> wrote:
> nbmake and chk are also good
>
>
>
> On Sat, Apr 4, 2009 at 10:26 AM, Piotr Jasiukajtis <estseg at gmail.com>
> wrote:
>> Hello,
>>
>> http://cr.opensolaris.org/~jmellors/ohac-tools-ksh88-93/usr/src/tools/scripts/nbuild.ksh.html
>>
>> nbuild changes look good at least for me ;)
>>
>> But, what about some changes I would suggest?
>>
>> 470 ? ? ? ? task=""
>> 474 ? ? ? ? ? ? ? ? export RELEASE_BUILD=""
>> 1305 ? ? ? ? whyfailed=""
>> 1411 ? ? ? ? (cd $dir && $func "$@"; echo $? >$xfile) 2>&1 | $TEE $log
>> 1433 ? ? ? ? ? ? ? ? (cd $dir && $pfunc $log; echo $? >$xfile) 2>&1 > $pplog
>>
>> btw, there are a lot of 'cd $foo; do_something'
>>
>> instead of
>>
>> 470 ? ? ? ? task=
>> 474 ? ? ? ? ? ? ? ? export RELEASE_BUILD=
>> 1305 ? ? ? ? whyfailed=
>> 1411 ? ? ? ? (cd $dir; $func "$@"; echo $? >$xfile) 2>&1 | $TEE $log
>> 1433 ? ? ? ? ? ? ? ? (cd $dir; $pfunc $log; echo $? >$xfile) 2>&1 > $pplog
>>
>>
>> On Sat, Apr 4, 2009 at 2:52 AM, Jonathan Mellors
>> <Jonathan.Mellors at sun.com> wrote:
>>> Hi Folks,
>>>
>>> When we started Colorado on opensolaris we discovered that some of our ksh
>>> scripts didn't work with ksh93, so we temporarily switched them to
>>> /usr/xpg4/bin/sh. I've now updated our build tools to be compatible with
>>> both ksh88 and ksh93.
>>>
>>> The changes are:
>>> - Change "local" to "typeset"
>>> - Change function declarations from "foo()" to "function foo" to ensure
>>> local variables don't leak out of their functions.
>>> - Fix incorrect variable declarations
>>> - Change "`...`" to "$(...)"
>>> - Internal ksh93 tee sometimes receives interrupts so force use of /bin/tee.
>>>
>>> http://cr.opensolaris.org/~jmellors/ohac-tools-ksh88-93/
>>>
>>> Thanks
>>> Jonathan
>>> _______________________________________________
>>> ha-clusters-discuss mailing list
>>> ha-clusters-discuss at opensolaris.org
>>> http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
>>>
>>
>>
>>
>> --
>> Regards,
>> Piotr Jasiukajtis | estibi | SCA OS0072
>> http://estseg.blogspot.com
>>
>
>
>
> --
> Regards,
> Piotr Jasiukajtis | estibi | SCA OS0072
> http://estseg.blogspot.com
>
--
Regards,
Piotr Jasiukajtis | estibi | SCA OS0072
http://estseg.blogspot.com
