Detlef,

Some comments and questions:
755         if ${ZLOGIN} ${SCHA_RESOURCE_GET} -R ${real_rs} -G 
${real_rg} -O Resource_state |${GREP} -i online >/dev/null 2>&1

This produces no output if the zone isn't booted. Would it be useful to 
add a message saying the zone isn't booted as well as the resource isn't 
online? It might be useful in determining why a resource wasn't on that 
zone - especially if you are debugging retrospectively.

Apart from that, it looks fine to me.

Regards,

Tim
---



On 04/08/09 12:41, Detlef Ulherr wrote:
> Hi,
> 
> The following two bugs are fixed for the HA-MySQL geocontrol:
> 
> 6827073 The validation of the geocontrol throws a syntax error if the 
> real mysql resource is not created
> 
> If the real mysql database is undefined on a cluster the validation 
> throws a syntax error because the nodelist is not initialized.
> 
> 
> 6822007 The HA-MySQL geocontrol should not execute takeover and 
> switchover actions on the wrong nodes
> 
> On a multi node cluster the functions check_switchover, check_takeover, 
> perform_switchover, and perform_takeover should return an error on all 
> nodes where the real mysql resource is offline.
> 
> The webrev for the two fixes is available under 
> http://cr.opensolaris.org/~ulherr/mysql-sbp-qafix/
> 
> The review period will time out on April 14.
> 
> Any comments are highly appreciated.
> 
> Kind Regards
> Detlef Ulherr
> 

-- 

Tim Read
Staff Engineer
Solaris Availability Engineering
Sun Microsystems Ltd
Springfield
Linlithgow
EH49 7LR

Phone: +44 (0)1506 672 684
Mobile: +44 (0)7802 212 137
Twitter: @timread

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

NOTICE: This email message is for the sole use of the intended 
recipient(s) and may contain confidential and privileged information. 
Any unauthorized review, use, disclosure or distribution is prohibited. 
If you are not the intended recipient, please contact the sender by 
reply email and destroy all copies of the original message.

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Reply via email to