Thanks Detlef, Prasad! Here is the updated webrev:
http://cr.opensolaris.org/~sdevulap/ha-jsas_6825447/
Thanks,
Swathi
On 04/14/09 10:10, Prasad Dharmavaram wrote:
> Swathi,
>
> Some comments:
>
> 1. Ln no. 1715 and 1716 is redundant. You don't have to set asenv_conf
> as you are
> not using it anywhere.
>
> *1710 pre_glassfish = B_TRUE;*
> *1711 (void) sprintf(asenv_conf, "%s/appserver/config/asenv.conf",*
> *1712 install_dir);*
> *1713 if (stat(asenv_conf, &statbuf) != 0) {*
> *1714 pre_glassfish = B_FALSE;*
> *1715 (void) sprintf(asenv_conf, "%s/config/asenv.conf",*
> *1716 install_dir);*
> *1717 }*
> *1718
>
>
> *
>
> 2. Based on asenv.conf stat() if it is pre or post glassfish post a
> DEBUG (high) log message.
> Also, provide detailed comments explaining the code changes.
>
>
> 3. Before integrating the code test 8.1 or 9.0 and of course the
> current glassfish version.
>
> Rest looks good.
>
> Thanks,
> --Prasad
>
> Swathi Devulapalli wrote:
>> Hi,
>>
>> Please review the changes I made for the HA-JSAS agent to address the
>> CR 6825447. The webrev is located at
>> http://cr.opensolaris.org/~sdevulap/ha-jsas_6825447/
>>
>> Details of the CR:
>>
>> If "Domaindir" property is not set , creation of a resource for
>> glassfish fails.
>> Since it takes the pre-defined configuration path , it fails to
>> create a resource with glassfish ,if we don't specify the Domaindir
>> property.
>> ================================================================
>>
>> clrs create -g glassfish-DAS-rg -t SUNW.jsas -p
>> Network_resources_used=loghost -p Adminuser=admin -p
>> Domain_name=domain1 -p
>> Passwordfile=/global/glassfish-1/glassfish/secret -p
>> Confdir_list=/global/glassfish-1/glassfish/ -y
>> resource_dependencies=hasp-DAS-rs glassfish-DAS-rs
>>
>> clrs: physhost3:global - Unable to open
>> </global/glassfish-1/glassfish//appserver/config/asenv.conf>: Bad
>> file number.
>>
>> clrs: (C189917) VALIDATE on resource glassfish-DAS-rs, resource
>> group glassfish-DAS-rg, exited with non-zero exit status.
>> clrs: (C720144) Validation of resource glassfish-DAS-rs in resource
>> group glassfish-DAS-rg on node pnass3 failed.
>> clrs: (C891200) Failed to create resource "glassfish-DAS-rs".
>>
>> ===================================================
>> If we don't specify this property ,the configuration file should be
>> set to a proper path in case of glassfish.
>>
>>
>> When Domain_dir extension property is not configured by the user,
>> it's value is being picked up from the asenv.conf file. The path to
>> file asenv.conf has been changed in glassfish. In the previous
>> releases, till Application Server 9.0, it was
>> $INSTALL_DIR/appserver/conf/asenv.conf. From the glassfish release
>> onwards, it has been changed to $INSTALL_DIR/conf/asenv.conf. The fix
>> addresses this requirement.
>>
>> Please let me know your comments by the end of Thursday 9th April, 2009.
>>
>> Thanks,
>> Swathi
>>
>> _______________________________________________
>> ha-clusters-discuss mailing list
>> ha-clusters-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://mail.opensolaris.org/pipermail/ha-clusters-discuss/attachments/20090414/d4f799da/attachment.html>
