Hi,

Please could you review this small change for HA-DHCP.

http://cr.opensolaris.org/~neilg/colorado-dhcp-6831051

The problem description is as follows:

When HA-DHCP fails over the DHCP client table from one node to another  
it runs pntadm (DHCP network table management utility) in batch mode  
using a generated file that contains the new server IP, i.e.

# cat /tmp/dhcp_dhcp-server-rs.tmp
pntadm -M 10.11.159.163 -s 10.11.159.47
pntadm -M 10.11.159.162 -s 10.11.159.47

However, if duplicate entries exist within /etc/hosts then the batch  
file is built incorrectly, i.e.

cat /tmp/dhcp_dhcp-server-rs.tmp
pntadm -M 10.11.159.163 -s 10.11.159.47
10.11.159.47 10.11.159.0                        <-- wrong
pntadm -M 10.11.159.162 -s 10.11.159.47
10.11.159.47 10.11.159.0                        <-- wrong

Consequently, line 623 "${PNTADM} -B ${TMPFILE}" within functions.ksh  
fails with,

pntadm [-r (resource)] [-p (path)] [-u (uninterpreted data)] (options)  
[(network ip or name)]

The fix ensures that only unique entries are returned from a "/bin/ 
getent hosts" call.

Regards
Neil




Reply via email to