Hi Thorsten, Thanks for the review...
Thorsten Frueauf wrote: > Hi Jonathan et al, > > one question and comment about usr/src/uts/Makefile.uts: > > - the comment within line 46-48 mentions "bugs". It would be useful if > we can mention the specific number there, if we have specific CRs in > mind. I'll have to defer to Hemachandran as he wrote that comment. > > - maybe related to those bugs, I notice that we will continue using the > -G option for ctfconvert. Does this mean we don't need the > "-qoption ccfe -features=noglobal" option for our C++ files? We've basically done the minimum necessary to get ctfconvert working as it did before Studio 12, so we've kept using the -G option for ctfconvert. As a separate exercise, I'll try switching the global options and see if it builds, but I don't think it should be part of this putback. > > Just trying to understand if "-xdebugformat=stabs" was the key point to > get ctfconvert to work? And I assume this then results into the > necessary information to be used by mdb? Yes the stabs flag was the key point in getting cftconvert to work. ON is supposed to be switching to Studio 12 in build 99, so at that point we'll see if they've used the same solution, or if the compiler dwarf output works for them. > > Though I don't think you seek review, the rest of the changes look fine > to me :) Thanks Jonathan > > Greets > Thorsten > > Jonathan Mellors wrote: > >> Hi Folks, >> >> Here's the webrev for switching our Core OS=5.11 builds to use the >> Studio 12 compiler and the StudioExpress 7/08 compiler on OpenSolaris. >> >> The key changes are: >> o Make Studio 12 the mandatory compiler for OS=5.11 builds (Studio 11 >> was optional inside Sun) >> o Default debug format for Studio 12 is dwarf, so force it to generate >> stabs for our debug tools >> o Studio 12 memory model is now specified with -m32/-m64 instead of >> -xarch options >> >> All of the above are specific to Studio 12. The Makefiles are >> configured to continue to use older compilers for our previously >> shipping S9/S10 product. >> >> Thanks to Thorsten for doing the initial trial run on opensolaris, and >> to Hemachandran for figuring out the new studio 12 compiler options. >> >> Webrev is at: >> http://cr.opensolaris.org/~jmellors/ohac-studio12/ >> >> Thanks >> Jonathan > >
