Hi Thorsten, I checked all the files and it looks good.
Thanks Jonathan Thorsten Frueauf wrote: > Hi Nick, Jonathan et al, > > sorry, but I actually forgot something. Since the data services man > pages are not within the data services gate, we have decided to not put > them into the individual data services IPS packages. > > Instead the documentation team will provide a separate data services man > page IPS package, similar to what we do for the core gate. > > Therefore I need to remove all the man pages from the manifest files. I > did comment them out for the packages we initially plan to submit, but > if we take above as a decision, I should remove them completely before I > do the putback. > > To provide you with an easier way to review, I created a child from my > child that has the ipsdefs changes, to just have a webrev about the man > page removal. Please review: > http://cr.opensolaris.org/~frueauf/coloradods-manifest-man-cleanup/ > > Once I get a "go" I will first putback that child into my initial child, > and then into the coloradods-gate :) > > One more comment below: > > Nicholas Solter wrote: > >> Thorsten Frueauf wrote: >> >>> Hi, >>> >>> after converting the SVR4 packages into IPS packages 1:1 for the core >>> framework gate, I did apply the same logic to now also convert the >>> agent gate. >>> >>> Please review the webrev at >>> http://cr.opensolaris.org/~frueauf/coloradods-gate-svr4-to-ips-autoconversion/ >>> >>> >>> >> >> Thorsten, >> >> I didn't look at every file, but the general structure looks fine. >> >> Now that you have a group package for the agents, we should add a >> dependency on it to the ha-cluster-full group package defined in the >> core gate. > > > Note that I did not create a group package for "ha-cluster-full" within > the core gate yet. I do have one for ha-cluster-framework-full. But the > data services should not be part of that. > > The group package to define "ha-cluster-full" needs to be freshly > created. I don't plan to do that as part of the data services gate > conversion. > > Greets > Thorsten >
