Hi Peter, > I just don't like goto's :-)
Fair enough. I dislike gotos as well, but I think they are a good solution for handling errors like in this case (and the cstyle guide also tolerates this). At any rate, here's the new webrev, which now only includes a minimal change (and that is definitely a good thing - I am still unhappy that I introduced the ret-error in my first suggestion): http://cr.opensolaris.org/~nigoroll/6895265_6895210_together_no_GOTO/ I've also done a test, which is documented in http://defect.opensolaris.org/bz/show_bug.cgi?id=12141#c5 >>>> http://cr.opensolaris.org/~nigoroll/bz12149_sdssc_host.c.patch >>> >>> Ah of course! It is not part of the ON base...apologies - separating >>> out these is good (ie have the ON ones and then the OHA one) and not >>> including it in the ON changes. >>> >>> Couple of comments here: >>> >>> o I'd called the variable mde (as per lots of the SVM code) >>> o initialise the variable with mdnullerror: >>> >>> md_error_t mde = mdnullerror; >> >> Thanks, I've changed the diff. > > For the OHA stuff the process to integrate is at: > > http://hub.opensolaris.org/bin/view/Community+Group+ha-clusters/sponsor-tasks To my understanding, these are the steps a sponsor is asked to follow. I will be happy to help where I can, but many things can only be done from within Sun/SWAN (like preparing the RTI, putting back etc.) - which is why I, as an external contributor, need a sponsor in the first place ;-) Ah, yes, I've signed the SCA a long time ago (SCA# OS0070). Nils
