I think engine-specific classes would be great. The only thing else I'd like to see is a better way to handle all the db_* functions in InstallHandler, which hold PHP code to execute when upgrading the DB. Since it's PHP, it's not DB-specific (as opposed to the schema/upgrades/*.sql files), but it seems it should be handled better than tacking on new methods every time.
One final thought: should upgrading the DB really be handled by the Installer? On Sun, Oct 12, 2008 at 7:14 PM, Graham Christensen < [EMAIL PROTECTED]> wrote: > > Andrew, > I would absolutely agree with you on the engine-specific code. There > is quite a bit of things in the installhandler that in my opinion might > do well outside of it, maybe in a separate Install class. > > The code I had started on the installhandler should probably be > replaced, I don't even recall how I left it, and hardly have time to use > my blog, let alone work on the code (although, I'd rather work on the > code than use it ;) > > I'd be more than willing to talk to someone (you? someone else?) > about what I learned, but I would imagine it wouldn't be hard to catch > up to where I was. > > Graham Christensen > > http://itrebal.com - Customized Web Hosting > [EMAIL PROTECTED] > > > > Andrew da Silva wrote: > > I know Graham Christensen (itrebal) was working on the InstallHandler, > > dunno what's the status on that or his ideas... > > > > But I was looking at the code of the InstallHandler and thinking > > there's way too much engine-specific code or checks... > > > > If there's one suggestion I'ld like to make is to not have things like > > below in the InstallHandler: > > if ( $db_type == 'sqlite' ) { > > > > Maybe have per-engine classes extend the InstallHandler or some other > > class, have an abstract class? > > > > A lot of people have been bashing the InstallHandler, let's her you! :) > > > > > > > > > > > --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/habari-dev -~----------~----~----~----~------~----~------~--~---
