We use extract() in several places in Habari, which at the least makes the code difficult to follow. I think it's legitimate in the theme engines, but is there any reason it's used in Comments::get(), EventLog::get(), Theme::act_display(), and Users::get() ? Don't we know what's possible to be passed, and can therefore get them directly from the array ? Yes, it's a bit more code, but it would be clearer.
This is a genuine question, and I'd be more than happy for someone to tell me "It's done this way because ..." and learn something. -- Michael C. Harris, School of CS&IT, RMIT University http://twofishcreative.com/michael/blog IRC: michaeltwofish #habari --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/habari-dev -~----------~----~----~----~------~----~------~--~---
