I would like to suggest an addition to Habari commit policy. When reverting a previous commit in whole due to a subjective issue (as opposed to an issue that causes demonstrable breakage or insecurity), some discussion on whether the revert should take place must take place, as is required by a veto based on technical grounds. This discussion needs to be recorded and available for the community to participate. The revert commit message must link to the discussion in a place where community-wide discussion can continue. In the case of a revert to fix breakage or insecurity, the commit message should clearly indicate the addressed issue, as usual.
Opening a thread for discussion even immediately before commiting a revert should be the minimal requirement for any revert. Subsequent discussion on the topic should determine the outcome of the code; whether to keep the original code or keep the reverted code. In most cases, a discussion on IRC precedes the revert, and in that case those present should be encouraged by the revert committer to record their +1/-1 on the linked thread to indicate that the revert had community support. I think the above is the best compromise between expedience and community review. It places little extra burden on the person committing the revert, and doesn't delay the commit process, while giving the community the opportunity for discourse. I would also suggest that committers whose code is the target of persistent reversion should have their commit privileges reviewed. If someone repeatedly commits something despite lack of community support, there's little reason to continue to let that person commit unwanted code. Please open separate threads to discuss the merits of specific past reverts if it is not directly relevant to this policy topic. Thanks. Owen --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/habari-dev -~----------~----~----~----~------~----~------~--~---
