I would like to propose moving this call:

Plugins::act( 'user_authenticate_successful', self::$identity );

found on line 283 of the user class to just after $user->remember()  
found on line 286. This will allow plugins to dictate arbitrary pages  
for the now logged in user to be redirected to. We currently have this:

self::$identity = $user;
Plugins::act( 'user_authenticate_successful', self::$identity );
EventLog::log( sprintf(_t('Successful login for %s'), $user- 
 >username), 'info', 'authentication', 'habari' );
// set the cookie
$user->remember();
return self::$identity;

And I would like to have this instead:

self::$identity = $user;
EventLog::log( sprintf(_t('Successful login for %s'), $user- 
 >username), 'info', 'authentication', 'habari' );
// set the cookie
$user->remember();
Plugins::act( 'user_authenticate_successful', self::$identity );
return self::$identity;

Are there any issues I am missing with this change?

Chris

--~--~---------~--~----~------------~-------~--~----~
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at http://groups.google.com/group/habari-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to