Just adding thoughts/bugs for formui. Seems like this can grow and
felt like it be discussed here before added as tickets.
*$form->aboutyou->id = 'about-you'; Doesn't change the id of the
fieldset.
But $form->content->id = 'commentContent'; does change the id of the
input.
*Doesn't seem to be any way to remove a label without creating a new
form and that's way to complicated.
*Rights now formui outputs both a div and a <input> with the same id.
It was suggested to do something like #control-whatever for the div
and then #whatever for the input.
But is that really necessary? The only reason for giving the inputs
ids would be for simpler styling and accessing using javascript.
But is doing #whatever input {} harder then doing #whatever? The same
goes for javascript. Imo it would be ok to just add an id to the outer
div.
* Adding the choice to use div, p or ul/li would be nice.
* It wouldn't hurt to use somewhat less common ids, #content, #name,
#url, #email might already be used. Why not add a prefix to them all?
#formui-name, #formui-url and so on.
* The submit <input> doesn't have an id. Not a big deal but either all
inputs should have ids or no.
My action_form_comment for reference. The actual form can be viewed at
http://dev.eighty4.se/fluffytag-yet-another-plugin-rewrite
public function action_form_comment($form) {
$form->class[] = 'box';
$form->append('fieldset', 'aboutyou', _t( 'A Little
About You' ) );
$form->aboutyou->id = 'about-you';
$form->move_before($form->aboutyou, $form->commenter);
$form->commenter->move_into($form->aboutyou);
$form->email->move_into($form->aboutyou);
$form->url->move_into($form->aboutyou);
$form->submit->move_into($form->aboutyou);
$form->append('fieldset', 'textarea', _t( 'Add to the
Discussion' ) );
$form->move_before($form->textarea, $form->content);
$form->content->id = 'commentContent';
$form->content->caption = '';
$form->content->move_into($form->textarea);
}
--~--~---------~--~----~------------~-------~--~----~
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at http://groups.google.com/group/habari-dev
-~----------~----~----~----~------~----~------~--~---
