On 2/8/2013 9:16 AM, Morgante Pell wrote:
I'm not convinced FormUI is such a bad system. It's one of the
beautiful bits of Habari.
I'm not suggesting its removal. I'm suggesting improvement.
I'm not saying we need to keep the API. I'm just asking what
specifically about the changes necessitates breaking the API.
There are many internal inconsistencies. Options, parameters,
settings... these things are shared and intermingled. It's not clear
which array is used in what case on what output element.
Saving control values is convoluted. I don't know how many times people
have tried to set the value of a control after they create it into the
form. This doesn't work. And I'm tired of explaining why. I think I'd
rather just make it work and let it people do what they expect with it.
Most of the changes I'm considering are along these lines - allowing
FormUI to make things easier by doing what people expect.
Unifying the template output is important because as we allow properties
to be set in a uniform way, the control templates must handle it.
Currently, even if you know in what place a property needs to be set, it
may not have the intended effect on the control because of the template
used (admin vs option vs tab vs regular). A better system is needed so
that you can rest assured when you set an option on a control, it
affects it regardless of the template used.
For when all else fails, attaching a FormUI class to an existing form
should be possible. For people that "just want to process this one
stupid custom form", FormUI should be able to help them out.
It could all be better, the above are the low points that, to me, are
more easily addressed by rethinking how it's done rather than spraying
on some new paint.
Why do things like this go ahead with minimal discussion?
This seems like a discussion to me. Things hardly ever happen solely as
a result of discussion around here.
Besides that, I think it's better to talk about changes in the concrete
than abstract. The refactor is in a branch. If consensus is that we
don't need/want it, it can stay there.
FormUI is one of the few parts of Habari that keep me up at night. I've
got some personal deadlines for not letting bits like this linger, so
I'm starting my effort now.
Owen
--
--
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at http://groups.google.com/group/habari-dev
---
You received this message because you are subscribed to the Google Groups "habari-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
