I've made a ton of changes in the comment system in master to enable
custom comment types and statuses.
There is a database migration that should move all of your data forward.
There were constants being used for the old comment statuses all over
the place. I tried to remove these everywhere in core, since they no
longer exist (and can't, since the values they hold will not match up
with what is in the database), but they are likely to exist in themes
and plugins that dealt with plugins.
Of particular interest is the thing that does moderated comment
checking, which is the only comment-related change I expect to happen in
most themes.
Rather than checking for this:
$comment->status == Comment::STATUS_UNAPPROVED
You can simply check for this:
$comment->is_unapproved
This construction should work for any type or status of a comment that
is in the database: is_comment, is_pingback, is_spam, etc.
There is some weirdness going on, possibly as a result of this change,
possibly as a result of the fluxing admin, possibly as a result of PHP -
I haven't fully investigated yet - that sometimes makes moderating
comments in the admin reset the type of the comment in the database to
an invalid value. This seems to be because when the comment is loaded
from the database, the Comment object's type value is incorrectly loaded
with null. This will need to be sorted out before release, obviously,
but it brings me to the conclusion:
YOU SHOULD NOT BE RUNNING MASTER IN PRODUCTION!
...especially if you rely on comments for useful things.
However, if folks can pitch in and clean up any anomalies (I've gone
through and done some crazy work on function comments, which may help
clarify some things), we can make quick work of putting the comment
system back to right AND picking up a cool new flexible feature at the
same time. Plus, the code is smaller.
Owen
--
--
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at http://groups.google.com/group/habari-dev
---
You received this message because you are subscribed to the Google Groups "habari-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
