Rick & Andy,
You guys were very helpful! It worked... Much appreciated with the
habari community being very accommodating and helpful!
Jeff
On Oct 29, 10:40 am, Andy C <[EMAIL PROTECTED]> wrote:
> Rick
>
> As always, many thanks for the considered and detailed reply in terms
> I can understand :-)
>
> That info helps to explain why the page navigation used to work (in
> Whitespace) and no longer does.
>
> The option of removing the assignment completely from 'theme.php' is
> an attractive one.
>
> Less is (almost always) more.
> --
> Andy
>
> On Oct 29, 11:29 am, rick c <[EMAIL PROTECTED]> wrote:
>
> > Andy,
>
> > To the best of my knowledge, yes, the addition of 'this' changes the
> > scope. Until about 6 months ago the page selector function was part of
> > the Utils class and $page was pretty much global. At that time the
> > page selector function was moved and became part of the Theme class,
> > of which all themes are subclasses. $page became part of the Theme
> > class, too.
>
> > In all actuality, the assignment that we're talking about here doesn't
> > really need to be done in the individual theme class, since
> > Theme::add_template_vars() assigns it and $user, so individual themes
> > don't have to assign either variable. Mzingi and Charcoal, for example
> > don't contain the $page assignment at all. K2 still does, but it could
> > be removed.
>
> > I hope this helps.
>
> > Rick
>
> > On Oct 29, 4:14 am, Andy C <[EMAIL PROTECTED]> wrote:
>
> > > Jeff - Yes. Rick is correct. The '$page' reference must be replaced
> > > with '$this->page' in two places.
>
> > > Rick - For the sake of completeness and my knowledge, does the
> > > addition of the 'this->' change the scope and the object being
> > > referenced here ?
>
> > > Initially, I thought this was a purely a cosmetic change and
> > > functionally equivalent.
> > > --
> > > Andy
>
> > > On Oct 29, 4:16 am, rick c <[EMAIL PROTECTED]> wrote:
>
> > > > Tatsui,
>
> > > > Andy was suggesting that you replace the current line with
>
> > > > $this->assign( 'page', isset( $this->page ) ? $this->page : 1 );
>
> > > > Rick
>
> > > > On Oct 28, 10:56 pm, Tatsui <[EMAIL PROTECTED]> wrote:
>
> > > > > Hi Andy,
>
> > > > > I'm note sure what you just wrote there but was able to find the code
> > > > > in the theme.php file on line 66. The php file already contains this
> > > > > line:
>
> > > > > LINE66: $this->assign('page', isset( $page ) ? $page : 1 );
> > > > > }
>
> > > > > I read over your comment a few times and not sure if you are
> > > > > suggesting to add the extra lines above the original line of command?
> > > > > I'm quite a novice with php files so bear with me. Much thanks for the
> > > > > help! Hopefully I get this straightened out. Thanks again! Let me
> > > > > know.
> > > > > Jeff
>
> > > > > On Oct 28, 11:09 am, Andy C <[EMAIL PROTECTED]> wrote:
>
> > > > > > $ diff theme.php theme.php~
> > > > > > 66c66
> > > > > > < $this->assign('page', isset( $this->page ) ? $this-
>
> > > > > > >page : 1 );
> > > > > > ---
> > > > > > > $this->assign('page', isset( $page ) ? $page : 1 );
>
> > > > > > fixes this problem.
>
> > > > > > On Oct 21, 1:50 pm, Andy C <[EMAIL PROTECTED]> wrote:
>
> > > > > > > Well, the relevant code snippet is in 'entry.multiple.php'
>
> > > > > > > entry.multiple.php: Page: <?php $theme->prev_page_link(); ?>
> > > > > > > <?php
> > > > > > > $theme->page_selector( null, array( 'leftSide' => 2, 'rightSide'
> > > > > > > =>
> > > > > > > 2 ) ); ?> <?php $theme->next_page_link(); ?>
>
> > > > > > > However, this is the same as K2 (which works) so this bug is
> > > > > > > obviously
> > > > > > > specific toWhitespace.
>
> > > > > > > Although I did the original port, I don't have a clue as I can't
> > > > > > > spell
> > > > > > > PHP.
>
> > > > > > > Hopefully, someone clever will wander along soon and help us out.
> > > > > > > --
> > > > > > > Andy
>
> > > > > > > On Oct 21, 6:34 am, Tatsui <[EMAIL PROTECTED]> wrote:
>
> > > > > > > > So it's been a week since I started using Habari. I have set to
> > > > > > > > publish 5 entries per page and notice the Next arrow and page
> > > > > > > > numbers
> > > > > > > > are showing on the bottom for users to go to the oldest
> > > > > > > > entries. I
> > > > > > > > didn't notice the bug until I got 3 pages up. The Next arrow
> > > > > > > > will only
> > > > > > > > go to Page 2 after clicking it. So from page 1 to 2 makes
> > > > > > > > sense, but
> > > > > > > > from 3 - 4 (clicking Next) will bring you back to Page 2. I
> > > > > > > > tried
> > > > > > > > looking to see where this error could be, but I haven't figured
> > > > > > > > it out
> > > > > > > > yet.
>
> > > > > > > > FYI - I'm usingWhitespacetheme on my habari.
--~--~---------~--~----~------------~-------~--~----~
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/habari-users
-~----------~----~----~----~------~----~------~--~---
