Hi Philip Aaaaahhh. This is going to be PHP's referencing. The way PHP handles referencing has changed over the years and it looks like may have changed again in PHP 5.3.0 (I tested with 5.2.12). I've not looked into these changes or under what circumstances objects can be passed by reference, but the last time I checked, there wasn't a need to pass an object by reference in PHP 5 (due to a change to the underlying code). Maybe PHP 5.3 has now put in some enforcement of this.
So from the way I see it, yes, your fix would be the correct one and I think we should remove the passing by reference in this plugin. Cheers, Colin PS. I'm in the UK too. On Tue, May 18, 2010 at 10:20 AM, Philip Buckley <[email protected]> wrote: > Hi Colin, > > Thanks for testing it for me. I too have have just now taken another look at > it, in the cool light of day (it is morning here in the UK), and before your > email came through. I changed two lines in the plugin, after which it works > for me. The lines are line 88 and 99: > > public function filter_theme_act_display_home( $handled, &$theme ) > public function filter_theme_act_display_blog_home( $handled, &$theme > ) > > In both lines I removed the ampersand before "$theme", so the lines read: > > public function filter_theme_act_display_home( $handled, $theme ) > public function filter_theme_act_display_blog_home( $handled, $theme > ) > > I am running Habari 0.6.4 and the plugin version 0.6-0.2 downloaded from > here http://www.habariproject.org/dist/plugins/staticfront/ > When I was getting the error yesterday I got it with the default theme as > well as with other themes I have installed but I didn't test it with no > other plugins installed. > The version of PHP running on my server is 5.3.0. > > My PHP isn't great, but I can't immediately think why there should be an > ampersand before "$theme" in those lines? If there is a reason and I > shouldn't change the lines as indicated, do let me know. > > Thanks > > Philip > > > On 18 May 2010, at 08:43, Colin wrote: > >> Hi Philip >> >> I've tested both the 0.6.4 and trunk versions of the StaticFront >> plugin and both work as expected. I suspect your problem may stem >> from another plugin or possibly a theme issue. >> >> Can you please test disabling all your plugins and use a default theme >> (eg K2) and see how it goes. If it continues to fail, please can you >> let us know: >> >> - what version of Habari you are running >> - which version of the staticfront plugin you are using >> - what errors you get when using a default theme (eg K2) and no other >> plugins >> >> If it works with a default theme and no other plugins, slowly >> introduce your plugins and theme one at a time until the problem comes >> to light. We should hopefully be able to work out from there where >> things are going wrong. >> >> HTH >> Colin >> >> On Mon, May 17, 2010 at 8:05 PM, Philip Buckley <[email protected]> >> wrote: >>> >>> Hi >>> >>> I am new to Habari. I have recently installed it and am exploring how >>> it works. I would like a home page (a page that appears first when >>> visiting the site). I have downloaded and installed the StaticFront >>> plugin. I created a new page to be the home page. I selected that page >>> in the Configure options for the plugin. I expected that page to >>> appear as the first page when I reloaded/revisited my site, but it >>> does not (nothing has changed). >>> >>> I have noticed that there is an error message in the logs: >>> >>> Parameter 2 to StaticFront::filter_theme_act_display_home() expected >>> to be a reference, value given in system/classes/plugins.php:94 >>> >>> Have I done something wrong? Have I misunderstood what the plugin is >>> supposed to do? Is there a problem with the plugin? >>> >>> Any advice appreciated >>> >>> Thanks >>> >>> Philip >>> >>> -- >>> To post to this group, send email to [email protected] >>> To unsubscribe from this group, send email to >>> [email protected] >>> For more options, visit this group at >>> http://groups.google.com/group/habari-users >> >> >> >> -- >> Colin Seymour >> Blog: http://colinseymour.co.uk >> Tech Stuff: http://www.lildude.co.uk >> Barefoot Running: http://barefootrunner.co.uk >> IRC: lildude #habari >> >> -- >> To post to this group, send email to [email protected] >> To unsubscribe from this group, send email to >> [email protected] >> For more options, visit this group at >> http://groups.google.com/group/habari-users > > -- > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/habari-users -- Colin Seymour Blog: http://colinseymour.co.uk Tech Stuff: http://www.lildude.co.uk Barefoot Running: http://barefootrunner.co.uk IRC: lildude #habari -- To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/habari-users
