commit 4d7091cae915b64e0c9d9dce6d45a5ed3e4dd622
Author: sin <[email protected]>
Date:   Mon Apr 14 11:22:28 2014 +0100

    Use *_FILENO instead of hardcoding constants

diff --git a/switch_root.c b/switch_root.c
index afbe328..b61a3a0 100644
--- a/switch_root.c
+++ b/switch_root.c
@@ -110,16 +110,13 @@ main(int argc, char **argv)
 
        /* if -c is set, redirect stdin/stdout/stderr to console */
        if (console) {
-               close(0);
-               if(open(console, O_RDWR) == -1){
+               close(STDIN_FILENO);
+               if(open(console, O_RDWR) == -1)
                        eprintf("open %s:", console);
-               }
-               if (dup2(0,1) == -1){
+               if (dup2(STDIN_FILENO, STDOUT_FILENO) != STDOUT_FILENO)
                        eprintf("dup2 %s:", "0,1");
-               }
-               if (dup2(0,2) == -1){
+               if (dup2(STDIN_FILENO, STDERR_FILENO) != STDERR_FILENO)
                        eprintf("dup2 %s:", "0,2");
-               }
        }
 
        /* execute init */


Reply via email to