On Tue, Jun 03, 2014 at 07:35:22PM +0200, Roberto E. Vargas Caballero wrote: > > Would vt100 be more sensible? Thing is if preserve == 0 we'll end up > > with TERM unset (for login specifically). > > login takes the value of TERM from its parent. If you executed login > in a telnet session, the telnet daemon will put the value. If you > have a SystemV inittab, then you configure in it the correct value of > TERM for every terminal. If you have a BSD /etc/ttys, then you configure > in it the correct value for every terminal. There is no other usages > of login, so the only way of getting a null value is a misconfiguration, > so you should to assume that the terminal only can handle the minimal > set of features, the features of a dumb terminal.
but -p is specifically used to tell login whether to preserve or discard the parent environment. What happens if -p is not set? I decided to put TERM=linux because ubase is linux specific. I agree with your statement when -p is set, in which case my patch has no effect (it won't overwrite TERM).
