[hackers] [sbase] ls: getpwuid, getgrgid, use return code of NULL is an error, not errno || Hiltjo Posthuma

[git]

commit 32651cb2da5b04e2fef1eef075374ef79e622ade
Author: Hiltjo Posthuma <hil...@codemadness.org>
Date:   Sun Dec 21 22:58:09 2014 +0100

    ls: getpwuid, getgrgid, use return code of NULL is an error, not errno

diff --git a/ls.c b/ls.c
index ef3f5f6..c864295 100644
--- a/ls.c
+++ b/ls.c
@@ -275,17 +275,17 @@ output(Entry *ent)
 
        errno = 0;
        pw = getpwuid(ent->uid);
-       if (errno || !pw)
-               snprintf(pwname, sizeof(pwname), "%d", ent->uid);
-       else
+       if (pw)
                snprintf(pwname, sizeof(pwname), "%s", pw->pw_name);
+       else
+               snprintf(pwname, sizeof(pwname), "%d", ent->uid);
 
        errno = 0;
        gr = getgrgid(ent->gid);
-       if (errno || !gr)
-               snprintf(grname, sizeof(grname), "%d", ent->gid);
-       else
+       if (gr)
                snprintf(grname, sizeof(grname), "%s", gr->gr_name);
+       else
+               snprintf(grname, sizeof(grname), "%d", ent->gid);
 
        if (time(NULL) > ent->mtime + (180*24*60*60)) /* 6 months ago? */
                fmt = "%b %d  %Y";