> Hey Markus,
Hi Makus, FRIGN :)

> > The error message strings should not be split over different lines,
> > even if they break the 80 character line length rule. On failure you
> > want to be able to grep for the exact error string in the source
> > code and
> >
> >     grep "unable to grab keyboard for screen"
> >
> > would not work anymore with the string broken into multiple lines.  
> 
> no offense, but this is just stupid. You should feel honored that
> Quentin is among the few here who take sane line-lengths seriously.
Personally I don't mind, but you could break the lines after each
argument and satisfy both churches. ;)
ie:
+               fprintf(stderr,
+                       "slock: unable to grab mouse pointer for
  screen %s\n",
+                       screen);
…
+               fprintf(stderr,
+                       "slock: unable to grab keyboard for screen
  %s\n",
+                       screen);


Reply via email to