On Fri, Sep 02, 2016 at 12:37:00PM +0100, Nick wrote:
> Hi FRIGN,
>
> I don't have time to look at this closely now, but one little thing
> that jumped out at me:
>
> > +static const struct {
> > + char *ext;
> > + char *type;
> > +} mimes[] = {
> > ...
>
> Why are you defining the struct in config.def.h? Shouldn't it be
> defined in quark.c, and then just populated in config.def.h. That is
> what other projects do, and it makes more sense, as the code in
> quark.c depends on the struct being defined a certain way.
>
> Nick
>
I disagree, aslong as it satisfies the members: char *ext, *type it will work.
The struct name itself is not defined or used anywhere. So the current code is
fine imho.
--
Kind regards,
Hiltjo
