On Sat, Oct 29, 2016 at 12:11 PM, Ali H. Fardan <r...@firemail.cc> wrote: > On 2016-10-29 12:40, Hiltjo Posthuma wrote: >> >> This is total bullshit: it is less readable and it makes no sense to >> optimize this case. Please fix real bugs. > > > uhm, like the dmenu one?[0] > > [0]: http://git.suckless.org/dmenu/tree/dmenu.c#n649 >
Not sure if you mean it sarcastically, but yes in dmenu it feelsgoodman.jpg. My gripe is checking: if (argv[1][1] == 'v' && argv[1][2] == '\0' && instead of using strcmp. This path is not "performance-critical" in any way, so it doesn't make sense. If you have anything to say, please respond with arguments.