On Tue, 22 Nov 2016 14:54:19 -0700 Bob Uhl <[email protected]> wrote: Hey Bob,
> I built slock from 1.4, with the same desktop-revealing result. This > is on Xorg 1.16.4, which supports RandR 1.4. > > I merged my patch into 1.4; it fixes the issue. > > The RandR protocol documentation at > <https://www.x.org/releases/X11R7.5/doc/randrproto/randrproto.txt> > indicates under 'RRScreenChangeNotify' (just before section 8.1): > > Note that the sizes in this event reflect the new SCREENSIZE and > thus will appear rotated by the 'rotation' parameter from the > sizes of the screen itself. In other words, when rotation is 90 or > 270, widthInPixels in this event will be the same as the height value > from a ConfigureNotify that reflects the same size change. > This will probably confuse developers. > > I suspect that it's only accidentally working for some folks with > portrait screens. I second this. @Markus: I totally forgot about this patch, but it is definitely valid and should be merged. Cheers Laslo -- Laslo Hunhold <[email protected]>
