This estrdup wasn't changed, potentially generating a segfault (if the codes 
somehow keeps going on) at line 140 of the current, unpatched code.

> @@ -157,7 +149,8 @@ runjob(char *cmd)
>                      cmd, ctime(&t));
>               _exit(EXIT_FAILURE);
>       } else {
> -             je = emalloc(sizeof(*je));
> +             if (!(je = emalloc(sizeof(*je))))
> +                     return;
>               je->cmd = estrdup(cmd);
>               je->pid = pid;
>               je->next = jobs;

Also, I don't see the point on keeping emalloc as it is given this changes. It 
should be renamed to xmalloc (because it doesn't error out at anymore) or 
completely deleted.

Reply via email to