Re: [hackers] [ubase][PATCH] passwd: fix crashes when authentication is unnecessary.

[Quentin Rameau]

Hey Mario,

> -     p = crypt(inpass, prevhash);
> -     if (!p)
> -             eprintf("crypt:");
> -     if (cryptpass1 && strcmp(cryptpass1, p) == 0)
> -             eprintf("password left unchanged\n");
> +     if (cryptpass1) {

            ^--- for more clarity, maybe check against prevhash instead?

> +             p = crypt(inpass, prevhash);
> +             if (!p)
> +                     eprintf("crypt:");
> +             if (strcmp(cryptpass1, p) == 0)
> +                     eprintf("password left unchanged\n");
> +     }