On 2018-10-01, David Phillips <[email protected]> wrote: > On Mon, Oct 01, 2018 at 06:35:13PM -0700, Michael Forney wrote: >> Rather than the if-else, I think we should always include sys/types.h, >> and also sys/sysmacros.h on glibc. I also think the comment is >> unnecessary. Do you mind if I apply with those two changes? > > I agree with that logic, so long as that doesn't hurt BSD systems (I > can't recall at the moment if sys/types.h exists on BSD)
Yes, sys/types.h is POSIX, so all systems will have it. I applied with the changes I mentioned. Thanks for the patch!
