On Mon, 21 Jan 2019 23:56:35 +0000
Oliver Galvin <[email protected]> wrote:

Dear Galvin,

I would object to such a change. We don't use EXIT_*-defines for a
reason.

With best regards

Laslo

> ---
>  st.c | 4 ++--
>  x.c  | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/st.c b/st.c
> index 5a8cdcc..4b5e725 100644
> --- a/st.c
> +++ b/st.c
> @@ -718,7 +718,7 @@ execsh(char *cmd, char *const *args)
>       signal(SIGALRM, SIG_DFL);
>  
>       execvp(prog, args);
> -     _exit(1);
> +     _exit(EXIT_FAILURE);
>  }
>  
>  void
> @@ -735,7 +735,7 @@ sigchld(UNUSED int a)
>  
>       if (!WIFEXITED(stat) || WEXITSTATUS(stat))
>               die("child finished with error '%d'\n", stat);
> -     exit(0);
> +     exit(EXIT_SUCCESS);
>  }
>  
>  void
> diff --git a/x.c b/x.c
> index 9e9bd3e..bd55699 100644
> --- a/x.c
> +++ b/x.c
> @@ -1751,7 +1751,7 @@ cmessage(XEvent *e)
>               }
>       } else if (e->xclient.data.l[0] >= 0 && (Atom)
> (e->xclient.data.l[0]) == xw.wmdeletewin) { ttyhangup();
> -             exit(0);
> +             exit(EXIT_SUCCESS);
>       }
>  }
>  
> -- 
> 2.20.1


-- 
Laslo Hunhold <[email protected]>

Attachment: pgp7PrP6soz3S.pgp
Description: PGP signature

Reply via email to