From af325040df94e8bb2bd130ab60bf0b3a4190250f Mon Sep 17 00:00:00 2001
From: Sebastian LaVine <[email protected]>
Date: Sun, 10 Jan 2021 22:56:41 -0500
Subject: [tabbed][PATCH] Remove quotes around variables from commands
Previously, if you had changed your PREFIX in config.mk to something
like ~/.local, then instead of installing to /home/user/.local, a
directory called '~' would be created in the project directory. Commands
are also performed without quotes in the Makefiles of other suckless
projects, like st or dwm.
---
Makefile | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/Makefile b/Makefile
index 1b95d15..acc3246 100644
--- a/Makefile
+++ b/Makefile
@@ -44,22 +44,22 @@ dist: clean
install: all
@echo installing executable files to ${DESTDIR}${PREFIX}/bin
- @mkdir -p "${DESTDIR}${PREFIX}/bin"
- @cp -f ${BIN} "${DESTDIR}${PREFIX}/bin"
- @chmod 755 "${DESTDIR}${PREFIX}/bin/tabbed"
+ @mkdir -p ${DESTDIR}${PREFIX}/bin
+ @cp -f ${BIN} ${DESTDIR}${PREFIX}/bin
+ @chmod 755 ${DESTDIR}${PREFIX}/bin/tabbed
@echo installing manual pages to ${DESTDIR}${MANPREFIX}/man1
- @mkdir -p "${DESTDIR}${MANPREFIX}/man1"
- @sed "s/VERSION/${VERSION}/g" < tabbed.1 >
"${DESTDIR}${MANPREFIX}/man1/tabbed.1"
- @chmod 644 "${DESTDIR}${MANPREFIX}/man1/tabbed.1"
- @sed "s/VERSION/${VERSION}/g" < xembed.1 >
"${DESTDIR}${MANPREFIX}/man1/xembed.1"
- @chmod 644 "${DESTDIR}${MANPREFIX}/man1/xembed.1"
+ @mkdir -p ${DESTDIR}${MANPREFIX}/man1
+ @sed "s/VERSION/${VERSION}/g" < tabbed.1 >
${DESTDIR}${MANPREFIX}/man1/tabbed.1
+ @chmod 644 ${DESTDIR}${MANPREFIX}/man1/tabbed.1
+ @sed "s/VERSION/${VERSION}/g" < xembed.1 >
${DESTDIR}${MANPREFIX}/man1/xembed.1
+ @chmod 644 ${DESTDIR}${MANPREFIX}/man1/xembed.1
uninstall:
@echo removing executable files from ${DESTDIR}${PREFIX}/bin
- @rm -f "${DESTDIR}${PREFIX}/bin/tabbed"
- @rm -f "${DESTDIR}${PREFIX}/bin/xembed"
+ @rm -f ${DESTDIR}${PREFIX}/bin/tabbed
+ @rm -f ${DESTDIR}${PREFIX}/bin/xembed
@echo removing manual pages from ${DESTDIR}${MANPREFIX}/man1
- @rm -f "${DESTDIR}${MANPREFIX}/man1/tabbed.1"
- @rm -f "${DESTDIR}${MANPREFIX}/man1/xembed.1"
+ @rm -f ${DESTDIR}${MANPREFIX}/man1/tabbed.1
+ @rm -f ${DESTDIR}${MANPREFIX}/man1/xembed.1
.PHONY: all options clean dist install uninstall
--
2.30.0
>From af325040df94e8bb2bd130ab60bf0b3a4190250f Mon Sep 17 00:00:00 2001
From: Sebastian LaVine <[email protected]>
Date: Sun, 10 Jan 2021 22:56:41 -0500
Subject: [PATCH] Remove quotes around variables from commands
Previously, if you had changed your PREFIX in config.mk to something
like ~/.local, then instead of installing to /home/user/.local, a
directory called '~' would be created in the project directory. Commands
are also performed without quotes in the Makefiles of other suckless
projects, like st or dwm.
---
Makefile | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/Makefile b/Makefile
index 1b95d15..acc3246 100644
--- a/Makefile
+++ b/Makefile
@@ -44,22 +44,22 @@ dist: clean
install: all
@echo installing executable files to ${DESTDIR}${PREFIX}/bin
- @mkdir -p "${DESTDIR}${PREFIX}/bin"
- @cp -f ${BIN} "${DESTDIR}${PREFIX}/bin"
- @chmod 755 "${DESTDIR}${PREFIX}/bin/tabbed"
+ @mkdir -p ${DESTDIR}${PREFIX}/bin
+ @cp -f ${BIN} ${DESTDIR}${PREFIX}/bin
+ @chmod 755 ${DESTDIR}${PREFIX}/bin/tabbed
@echo installing manual pages to ${DESTDIR}${MANPREFIX}/man1
- @mkdir -p "${DESTDIR}${MANPREFIX}/man1"
- @sed "s/VERSION/${VERSION}/g" < tabbed.1 > "${DESTDIR}${MANPREFIX}/man1/tabbed.1"
- @chmod 644 "${DESTDIR}${MANPREFIX}/man1/tabbed.1"
- @sed "s/VERSION/${VERSION}/g" < xembed.1 > "${DESTDIR}${MANPREFIX}/man1/xembed.1"
- @chmod 644 "${DESTDIR}${MANPREFIX}/man1/xembed.1"
+ @mkdir -p ${DESTDIR}${MANPREFIX}/man1
+ @sed "s/VERSION/${VERSION}/g" < tabbed.1 > ${DESTDIR}${MANPREFIX}/man1/tabbed.1
+ @chmod 644 ${DESTDIR}${MANPREFIX}/man1/tabbed.1
+ @sed "s/VERSION/${VERSION}/g" < xembed.1 > ${DESTDIR}${MANPREFIX}/man1/xembed.1
+ @chmod 644 ${DESTDIR}${MANPREFIX}/man1/xembed.1
uninstall:
@echo removing executable files from ${DESTDIR}${PREFIX}/bin
- @rm -f "${DESTDIR}${PREFIX}/bin/tabbed"
- @rm -f "${DESTDIR}${PREFIX}/bin/xembed"
+ @rm -f ${DESTDIR}${PREFIX}/bin/tabbed
+ @rm -f ${DESTDIR}${PREFIX}/bin/xembed
@echo removing manual pages from ${DESTDIR}${MANPREFIX}/man1
- @rm -f "${DESTDIR}${MANPREFIX}/man1/tabbed.1"
- @rm -f "${DESTDIR}${MANPREFIX}/man1/xembed.1"
+ @rm -f ${DESTDIR}${MANPREFIX}/man1/tabbed.1
+ @rm -f ${DESTDIR}${MANPREFIX}/man1/xembed.1
.PHONY: all options clean dist install uninstall
--
2.30.0
