Hi Hiltjo, > They arrived properly. I've read most of the patches. It's a bulk of patches > so please give me some time to review it.
Sure, no problem! > Some quick notes (will write it more detailed later): Thanks, I already picked these up, I'll submit 4 new patches that address these (on top of the 24, I could do some rebasing to squash some of them). > - Add an util function estrdup() and check all memory allocations. Check, added now > - Theres a warning about a ShiftMask macro (clang on OpenBSD). Good catch! Didn't see that with gcc, this was an actual bug in the use of the ternary operator > - Change to a consistent code-style and trailing white-space/TAB issues. Right, especially the layouts were a bit inconsistent with indentation, I fixed that now. > - The commit "fixed double free error" also changed the Makefile (added -g). Oops, that was indeed not the intention. Thanks for the feedback! -- Maarten van Gompel [email protected] https://proycon.anaproy.nl https://github.com/proycon GnuPG key: 0x39FE11201A31555C XMPP: [email protected] Matrix: @proycon:matrix.anaproy.nl Telegram: proycon IRC: proycon (freenode) Mastodon: https://social.anaproy.nl/@proycon (@[email protected]) Twitter: https://twitter.com/proycon
