On Sat, Apr 30, 2022 at 10:45:09AM +0600, NRK wrote:
> On Fri, Apr 29, 2022 at 08:19:20PM +0200, g...@suckless.org wrote:
> > commit e1e1de7b3b8399cba90ddca9613f837b2dbef7b9
> > Author: Hiltjo Posthuma <hil...@codemadness.org>
> > AuthorDate: Fri Apr 29 20:15:48 2022 +0200
> > Commit: Hiltjo Posthuma <hil...@codemadness.org>
> > CommitDate: Fri Apr 29 20:18:02 2022 +0200
> >
> > inputw: improve correctness and startup performance, by NRK
> >
> > Always use ~30% of the monitor width for the input in horizontal mode.
> >
> > Patch adapted from NRK patches.
> > This also does not calculate inputw when using vertical mode anymore
> > (because
> > the code is removed).
> >
> > diff --git a/dmenu.c b/dmenu.c
> > index 839f6cc..4e286cf 100644
> > --- a/dmenu.c
> > +++ b/dmenu.c
> > @@ -610,13 +610,12 @@ static void
> > setup(void)
> > {
> > int x, y, i, j;
> > - unsigned int du, tmp;
> > + unsigned int du;
> > XSetWindowAttributes swa;
> > XIM xim;
> > Window w, dw, *dws;
> > XWindowAttributes wa;
> > XClassHint ch = {"dmenu", "dmenu"};
> > - struct item *item;
> > #ifdef XINERAMA
> > XineramaScreenInfo *info;
> > Window pw;
> > @@ -674,12 +673,7 @@ setup(void)
> > mw = wa.width;
> > }
> > promptw = (prompt && *prompt) ? TEXTW(prompt) - lrpad / 4 : 0;
> > - for (item = items; item && item->text; ++item) {
> > - if ((tmp = textw_clamp(item->text, mw/3)) > inputw) {
> > - if ((inputw = tmp) == mw/3)
> > - break;
> > - }
> > - }
> > + inputw = mw / 3; /* input width: ~30% of monitor width */
> > match();
> >
> > /* create menu window */
> >
>
> Hi Hiltjo,
>
> Thanks for getting on this quickly.
>
> I prefered the static bar width as it gives a predictable UI, the first
> option will always appear in the same place rather than jumping around
> depending on the input strings. And the fact that there was no way to
> calculate the width correctly without taking unreasonable performance
> hit anyways.
>
> Though I must admit I'm having some second thoughts about it now. Given
> that not taking fallback fonts "worked fine" (haven't seen anyone
> complain) for about 6 years, maybe that wasn't too bad of an option.
>
> But in any case, I'm fine with the current patch too, though I've
> changed it to 1/4th of the monitor width rather than 1/3rd as I found
> that too wide for my liking.
>
> - NRK
>
Hi NRK,
What monitor resolution width do you have? I use 1920x1080 on this machine.
The previous maximum width also used about 30% of the monitor width.
--
Kind regards,
Hiltjo
