On Thu, Jul 14, 2022 at 07:26:40AM +0600, NRK wrote:
> die() calls vprintf, fputc and exit; none of these are
> async-signal-safe, see `man 7 signal-safety`.
> ---
> dwm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/dwm.c b/dwm.c
> index 5646a5c..8358fb0 100644
> --- a/dwm.c
> +++ b/dwm.c
> @@ -1541,6 +1541,8 @@ setup(void)
> Atom utf8string;
>
> /* clean up any zombies immediately */
> + if (signal(SIGCHLD, sigchld) == SIG_ERR)
> + die("can't install SIGCHLD handler:");
> sigchld(0);
>
> /* init screen */
> @@ -1638,8 +1640,6 @@ showhide(Client *c)
> void
> sigchld(int unused)
> {
> - if (signal(SIGCHLD, sigchld) == SIG_ERR)
> - die("can't install SIGCHLD handler:");
> while (0 < waitpid(-1, NULL, WNOHANG));
> }
>
> --
> 2.35.1
>
>
Hi NRK,
Thanks for the patches as usual :)
I applied and pushed the patches,
--
Kind regards,
Hiltjo
