Hi Cris, > I originally sent these a few years ago and the reply was that > const-correctness wasn't something cared about, but seeing other const > changes in dwm, and purely const-correctness improvements in > quark/st/libgrapheme, I figured maybe it's worth reevaluating and seeing > if they are of interest now.
I think that the stance is still the same. > These changes primarily avoid casting away const unnecessarily. They > also make sure that we don't accidentally introduce non-const behaviour > in future, and potentially UB. Those don't “cast away constantness”, they are just cast. While it could be argued that it makes sense to declare a variable as const, it seems that modifying an already present cast for that is more bikeshedding than bringing actual value. To me, those are unuseful here, just my opinion.
