Re: [hackers] [dmenu] tab-complete: figure out the size before copying || NRK

[Santtu Lakkala]

On 2.9.2022 14.01, g...@suckless.org wrote:

commit 528d39b011afb7ef6fd794ba6b74155d4e69bc68

dmenu.c b/dmenu.c

index 969f6d8..6b285df 100644
--- a/dmenu.c
+++ b/dmenu.c
@@ -517,9 +517,9 @@ insert:
        case XK_Tab:
                if (!sel)
                        return;
-               strncpy(text, sel->text, sizeof text - 1);
+               cursor = strnlen(sel->text, sizeof text - 1);
+               memcpy(text, sel->text, cursor);
                text[sizeof text - 1] = '\0'

This should now be
text[cursor] = '\0';

(Try, for example:
printf "short\nlongerstring\n" | dmenu

and type in: lon<TAB><Home>^Ks<TAB>
and end up with shortgerstring)

-               cursor = strlen(text);
                match();
                break;
        }

--
Santtu