On Sun, 2 Oct 2022 09:29:18 +0600
NRK <[email protected]> wrote:

Dear NRK,

> - to_case: there's no `len` parameter. it should be `srclen` and
> `dstlen`.
> - is_case: `caselen` should be a pointer.
> ---
> 
> P.S: one more thing that caught my eye; the "next" manpages for the
> codepoint versions states:
> 
>       If len is set to SIZE_MAX the string str is interpreted to be
>       NUL-terminated and processing stops when a NUL-byte is
>       encountered.
> 
> is this correct? what if the integer contains a nul-byte?
> 
> it seems to be that it should be an integer (uint_least32_t) with the
> value 0, not a nul-byte, which are different things.

thanks for reporting these problems! I actually had on my TODO to take
a look at the manuals, given there were also some other problems.

I now took the time to fix them all[0], including your suggestions.
Thank you very much!

The wording regarding the "NUL-byte" was a bit unfortunate for the
codepoint-based functions. I fixed it up accordingly.

With best regards

Laslo

[0]:https://git.suckless.org/libgrapheme/commit/995e37182dc53da55dc4cf34868513610215c79e.html

Reply via email to