Hiltjo Posthuma writes:
Thanks for the patch, I will probably look at it further this weekend.
Thanks for looking! :-)
Should syms be checked before XFree(syms) or can the return value not be NULL?
I was going to say that it's not possible even with a race with a new mapping, since XDisplayKeycodes() just tells us what the min/max possible keycodes are for this display, regardless of future changes in the mapping. However, looking at the source, I also see that we do actually return NULL for another reason not documented in the man page: if the internal Xmallocarray() fails. I'll add the guard and send v2. Thanks!
