On Mon, Jan 09, 2023 at 03:07:48PM +0000, Augusto Castelo wrote:
> ffprepare was allocating a new XImage but wasn't freeing the
> previously allocated one
> ---
> sent.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/sent.c b/sent.c
> index 9534fca..d949d71 100644
> --- a/sent.c
> +++ b/sent.c
> @@ -270,6 +270,9 @@ ffprepare(Image *img)
> if (depth < 24)
> die("sent: Display color depths < 24 not supported");
>
> + if (img->ximg)
> + XDestroyImage(img->ximg);
> +
> if (!(img->ximg = XCreateImage(xw.dpy, CopyFromParent, depth, ZPixmap,
> 0,
> NULL, width, height, 32, 0)))
> die("sent: Unable to create XImage");
> --
> 2.39.0
>
Applied, thank you.
The memory leak was easily reproducable by opening sent:
sent < example
... and then resizing the nyancat window.
--
Kind regards,
Hiltjo
