On Sat, Jan 28, 2023 at 12:53:48PM +0100, Hiltjo Posthuma wrote:
> waitpid() and sigaction() can also fail with EINTR, which may mean our zombie
> handling fails, so block signals while setting things up to be careful.

IMO this line should be removed from the commit message because:

* It's not accurate (afaik) becasuse EINTR isn't specified for `sigaction`:
  https://www.man7.org/linux/man-pages/man3/sigaction.3p.html#ERRORS
* the signal blocking got removed from the final patch anyways.

But otherwise it's looking OK to me :)

- NRK

Reply via email to