On Sun, Jun 25, 2023 at 05:38:33AM +0000, Shi Tian wrote:
> Under insert mode, when inserting a normal character in front of
> a wide character, the affected region is shifted to the right by
> one cell. However, the empty cell is reset as if being a part of a
> wide character, causing the following cell being mishandled as a
> dummy cell.
> To reproduce the bug:
> printf '\033[4h' # set MODE_INSERT
> printf 妳好
> printf '\033[4D'
> printf 'x'
> printf '\033[4l\n'
> ---
> st.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/st.c b/st.c
> index a3d1697..8a9306a 100644
> --- a/st.c
> +++ b/st.c
> @@ -2495,8 +2495,10 @@ check_control_code:
> gp = &term.line[term.c.y][term.c.x];
> }
>
> - if (IS_SET(MODE_INSERT) && term.c.x+width < term.col)
> + if (IS_SET(MODE_INSERT) && term.c.x+width < term.col) {
> memmove(gp+width, gp, (term.col - term.c.x - width) *
> sizeof(Glyph));
> + gp->mode &= ~ATTR_WIDE;
> + }
>
> if (term.c.x+width > term.col) {
> tnewline(1);
> --
> 2.29.2
>
>
Hi Shi Tian,
Thanks for the patch, it looks good, I've pushed it to master.
--
Kind regards,
Hiltjo
