--On Wednesday, October 13, 2004 10:59 AM -1000 "(Cedric) Qin ZHANG" <[EMAIL PROTECTED]> wrote:
2. I run checkstyle everytime before my commit, including last time. The problem is the last time checkstyle ran, it reported only one error in hackyReport package (I notified Hongbing).
I did not expect checkstyle to stop after detecting errors in one module. I had thought that it had gone through all the modules. But still, my bad.
I've said it before at least three times, I'll say it once again:
The way to minimize the risk of breaking the daily build is to do 'ant -q freshStart junitAll'
"Running checkstyle everytime before my commit" is not nearly good enough.
As an example, before I committed my stuff this morning, I ran 'freshStart junitAll' (it cost me five minutes). Then I committed.
Then, I did a cvsUpdateAll, and re-ran freshStart junitAll while I was doing something else just to make sure that there wasn't any commits just now that might break things. (Another five minutes, but not much cost, I was doing something else.)
The build can still break, for example if you don't have all of the modules enabled. But doing a freshStart junitAll is really the way to go.
I guess at some point we could do an analysis where we collect the ant targets people invoke and correlate build failures to the presence/absence of 'freshStart junitAll' prior to the commit.
Cheers, Philip
