My comments on Aaron's proposal.
I think we should stick to "data" not "propertyList". It is simple and follows naming convention. It's a great and simple solution to add dailybuild key-value pair to all snap-shot data. We have "runtime" to SDTS like coverage and file metrics but they don't indicate dailybuild. However, this change has to be backward compatible otherwise all student's project telemetry stream will go wild. Add please note that daily build may build system more than once a day so dailybuild attribute is not a remedy for all.
To file metrics I don't agree we should move class name to data field. Class name is mandatory because we need it to look up for file name in WorkspaceMapManager. Plus all keys in data field are about measures to the class and file.
Hope it helps! Hongbing
At 02:46 AM 3/10/2005, Aaron Kagawa wrote:
Hey Guys,
As a result of our code review on hackyPRI, I've started on a design document for the improvement of Hackystat's Snapshot measures. You can view it here: <http://hackystat.org/hackyDevSite/doc/SnapshotEnhancements.html>.
In the document, I explain what needs to happen. There are 7 measures (Build, Coverage, FileMetric, UnitTest, Dependency, Issue, and Perf) that need to be changed. Each measure will require 4 changes; SDT, Sensor, Sensor Data Entry class, and DailyProjectData. (haha. so that's 28 big changes!) I've tried to include changes to the SDTs that go beyond just the Snapshot required fields. And I've tried to standardize naming conventions for the attributes. For example, renaming additionaldata to propertyList, moving className to the propertyList, or consistantly naming the runtime timestamp attribute: "runtime".
Please take a look. Questions and suggestions are encouraged. Pay special attention to the proposed changes to the SDTs. I really need the Evolutionary Sensor Data Types to be able to do this easily. Someone want to volunteer for that?
My time line for this is that I hope to get this completed by the end of Spring Break!
thanks, aaron
