Greetings, team:
I have a review request of the TimeZoneChanger (a single Java File) that I was hoping people could look at before Monday (04/25) or even on Wednesday (04/27). This code is pretty critical, however all you probably need is 15-20 minutes to read some of the code. If you have some spare time, then read on:
Note that we are still scheduled to review Mike's code on Monday and Christoph's code on Wednesday.
Time Permitting, Monday (04.25.2005) or Wednesday (04.27.2005) at noon in POST 307, we will be discussing the review of the TimeZoneChanger in the org.hackystat.kernel.admin package.
Please make sure you install the latest version of Jupiter and Jupiter sensor. Otherwise you might not send the correct data to the server. ----------------------------------
To perform this review: 1) Install and/or update (a) the Eclipse Jupiter plug-in and (b) The Hackystat Jupiter sensor. 2) Checkout/Update the hackyKernel module from CVS. 3) Select "TimeZoneChanger" as the ReviewID. ----------------------------------
Please focus your attention on: - Correctness - I've just made an improvement to change all test user data (ie, testdataset, testpridataset, testuserCgqm, etc). I just recently realized that this is pretty scary because there could be the possibility of changing everyones' data (even normal users). Please check that this is not possible. I'm 99.999999% sure it is not possible. See the changeTestData() method.
Background Information: - I've used this code quite extensively (well almost every day in Pasadena) during the summer. I've seen no problems with its implementation. Just recently I made a small change to the code and began to wonder if it is in fact bug free. - Time Zone and Daylight saving considerations are major complicating factors in this code.
Thank you for reviewing the code!
Aaron ------------------------------------------------------------- Supplemental Links and Resources:
The Hackystat Code Review Guidelines: * http://hackydev.ics.hawaii.edu/hackyDevSite/doc/Review.html
The Elements of Hacky Style: * http://hackydev.ics.hawaii.edu/hackyDevSite/doc/EHS.html
Jupiter Code Review Tool documentation: * http://csdl.ics.hawaii.edu/Tools/Jupiter/Core/doc/UsersGuide.html
Hackystat Jupiter Sensor documentation: * http://hackystat.ics.hawaii.edu/hackystat/docbook/apas15.html
